[GitHub] [spark] cloud-fan commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-644620657 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-643965087 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-643873707 Why are there empty golden files generated in `sql/hive/src/test/resources/golden`? This is an automated

[GitHub] [spark] cloud-fan commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-642511794 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-637217206 You can change `Cast(Cast(UnixTimestamp(left, format), TimestampType), DateType))` to `Cast(SecondsToTimestamp(UnixTimestamp(left, format)), DateType))`

[GitHub] [spark] cloud-fan commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-635757370 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-634571852 these are legitimate test failures. Can you update the test, or set the legacy config in these tests? This

[GitHub] [spark] cloud-fan commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-634505252 can we also add an item in `docs/sql-migration-guide.md`? This is an automated message from the Apache Git