[GitHub] [spark] cloud-fan commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-02-08 Thread GitBox
cloud-fan commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-774975197 The last commit just updates a comment, merging to master, thanks! This is an automated message from the Apach

[GitHub] [spark] cloud-fan commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-01-26 Thread GitBox
cloud-fan commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-767655443 @beliefer do we have some real examples that have issues before because the expr ID is changed? This is an au

[GitHub] [spark] cloud-fan commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-01-25 Thread GitBox
cloud-fan commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-766928084 Can we be more specific about the benefits? If we only want to unify the schema, we can directly change `ShowTablesCommand.output`. Passing around the output attributes should

[GitHub] [spark] cloud-fan commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-01-25 Thread GitBox
cloud-fan commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-766928084 Can we be more specific about the benefits? If we only want to unify the schema, we can directly change `ShowTablesCommand.output`. Passing around the output attributes should