[GitHub] [spark] cloud-fan commented on pull request #38513: [SPARK-40903][SQL][FOLLOWUP] Cast canonicalized Add as its original data type if necessary

2022-11-07 Thread GitBox
cloud-fan commented on PR #38513: URL: https://github.com/apache/spark/pull/38513#issuecomment-1306748021 We should not change query semantics after reordering, as this is canonicalization. It's hard to convince people that different result types still guarantee the same query semantic.

[GitHub] [spark] cloud-fan commented on pull request #38513: [SPARK-40903][SQL][FOLLOWUP] Cast canonicalized Add as its original data type if necessary

2022-11-06 Thread GitBox
cloud-fan commented on PR #38513: URL: https://github.com/apache/spark/pull/38513#issuecomment-1305100077 I think canonicalization should not change the data type in the first place. Adding cast only hides the bug. What's worse, it doesn't help with the goal of canonicalization: match