[GitHub] [spark] cloud-fan commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

cloud-fan commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1491261819 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] cloud-fan commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

cloud-fan commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1482331121 > any UnresolvedFunction should have UnresolvedAlias. SGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] cloud-fan commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

cloud-fan commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1471235372 The single quote indicates that the expression is unresolved, I think it doesn't matter here. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

cloud-fan commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1465459756 The auto-generated alias name is fragile and we are trying to improve it at https://github.com/apache/spark/pull/40126 Can you give some examples of how the new update changes

[GitHub] [spark] cloud-fan commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

cloud-fan commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1463337176 I think the test is easy to fix. It wants to test the aggregate function result, but not the generated alias, so we just change the testing query to add alias explicitly. ``` val

[GitHub] [spark] cloud-fan commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

cloud-fan commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1459854807 > Apparently having all expr as unresolvedAlias is not working. Can you share the test failures? Maybe we just need to update the tests with the different alias name. -- This