[GitHub] [spark] cryeo commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if function

2019-06-09 Thread GitBox
cryeo commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if function URL: https://github.com/apache/spark/pull/24335#discussion_r291876326 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountIf.scala

[GitHub] [spark] cryeo commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if function

2019-06-07 Thread GitBox
cryeo commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if function URL: https://github.com/apache/spark/pull/24335#discussion_r291725734 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ## @@ -894,4

[GitHub] [spark] cryeo commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if function

2019-06-06 Thread GitBox
cryeo commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if function URL: https://github.com/apache/spark/pull/24335#discussion_r291444380 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountIf.scala