[GitHub] [spark] dchvn commented on a change in pull request #34673: [SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-12-06 Thread GitBox
dchvn commented on a change in pull request #34673: URL: https://github.com/apache/spark/pull/34673#discussion_r763604274 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala ## @@ -1073,6 +1076,81 @@ object JdbcUtils extends Lo

[GitHub] [spark] dchvn commented on a change in pull request #34673: [SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-12-05 Thread GitBox
dchvn commented on a change in pull request #34673: URL: https://github.com/apache/spark/pull/34673#discussion_r762668281 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala ## @@ -71,6 +71,14 @@ private[v2] trait V2JDBC

[GitHub] [spark] dchvn commented on a change in pull request #34673: [SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-11-30 Thread GitBox
dchvn commented on a change in pull request #34673: URL: https://github.com/apache/spark/pull/34673#discussion_r759855352 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala ## @@ -1078,26 +1080,50 @@ object JdbcUtils extends L

[GitHub] [spark] dchvn commented on a change in pull request #34673: [SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-11-29 Thread GitBox
dchvn commented on a change in pull request #34673: URL: https://github.com/apache/spark/pull/34673#discussion_r758113045 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala ## @@ -164,4 +172,78 @@ private object PostgresDialect extends JdbcDi