[GitHub] [spark] dilipbiswal commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-09 Thread GitBox
dilipbiswal commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-656483187 @dongjoon-hyun Thank you very much :-) This is an automated message from the Apache Git Service. To

[GitHub] [spark] dilipbiswal commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-08 Thread GitBox
dilipbiswal commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-655802649 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dilipbiswal commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-06 Thread GitBox
dilipbiswal commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-654350946 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dilipbiswal commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-06 Thread GitBox
dilipbiswal commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-654054782 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dilipbiswal commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-02 Thread GitBox
dilipbiswal commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-653252281 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dilipbiswal commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-02 Thread GitBox
dilipbiswal commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-653212797 @cloud-fan > Shall we add a rule to remove all hint nodes at the beginning if the conf is set? This is future-proof in case we add new hint resolution rules in the

[GitHub] [spark] dilipbiswal commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-06-20 Thread GitBox
dilipbiswal commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-647056530 @dongjoon-hyun Thank you for the comments. I was thinking, if users add hints through extensions, isn't it reasonable to expect them to code to this new configuration ? I

[GitHub] [spark] dilipbiswal commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-06-20 Thread GitBox
dilipbiswal commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-646955288 retest this please This is an automated message from the Apache Git Service. To respond to the message,