[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#discussion_r291436969 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountIf.scala #

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#discussion_r291433907 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ## @@ -894,

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#discussion_r291433432 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ## @@ -894,

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#discussion_r291433282 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ## @@ -894,

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#discussion_r291432774 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountIf.scala #

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#discussion_r291431861 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountIf.scala #