dongjoon-hyun commented on code in PR #37745: URL: https://github.com/apache/spark/pull/37745#discussion_r960841601
########## hadoop-cloud/pom.xml: ########## @@ -135,6 +135,18 @@ </exclusion> </exclusions> </dependency> + <dependency> + <groupId>com.google.cloud.bigdataoss</groupId> + <artifactId>gcs-connector</artifactId> + <version>${gcs-connector.version}</version> + <classifier>shaded</classifier> + <exclusions> + <exclusion> + <groupId>*</groupId> Review Comment: Thank you for review, @sunchao . According to the shaded pattern, https://github.com/GoogleCloudDataproc/hadoop-connectors/blob/8453ce7ce7510e983bae7470909fbd02704c0539/gcs/pom.xml#L208-L363 We have all we needed for Hadoop3 and Hadoop2. - For Hadoop3, https://mvnrepository.com/artifact/com.google.cloud.bigdataoss/gcs-connector/hadoop3-2.2.7 - For Hadoop2, https://mvnrepository.com/artifact/com.google.cloud.bigdataoss/gcs-connector/hadoop2-2.2.7 I intentionally exclude everything. We will add Spark's version if there is additional missing transitive dependency (if exists). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org