dongjoon-hyun commented on code in PR #37879: URL: https://github.com/apache/spark/pull/37879#discussion_r973544556
########## core/src/test/scala/org/apache/spark/SparkFunSuite.scala: ########## @@ -299,10 +299,15 @@ abstract class SparkFunSuite parameters: Map[String, String] = Map.empty, matchPVals: Boolean = false, queryContext: Array[QueryContext] = Array.empty): Unit = { - assert(exception.getErrorClass === errorClass) + val mainErrorClass :: tail = errorClass.split("\\.").toList + assert(tail.isEmpty || tail.length == 1) + // TODO: remove the `errorSubClass` parameter. Review Comment: just nit. If we use IDed TODO, some contributor can pick up the item more easily. ########## core/src/test/scala/org/apache/spark/SparkFunSuite.scala: ########## @@ -299,10 +299,15 @@ abstract class SparkFunSuite parameters: Map[String, String] = Map.empty, matchPVals: Boolean = false, queryContext: Array[QueryContext] = Array.empty): Unit = { - assert(exception.getErrorClass === errorClass) + val mainErrorClass :: tail = errorClass.split("\\.").toList + assert(tail.isEmpty || tail.length == 1) + // TODO: remove the `errorSubClass` parameter. Review Comment: just nit. If we use IDed TODO with JIRA id, some contributor can pick up the item more easily. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org