dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update
testthat to >= 2.0.0
URL: https://github.com/apache/spark/pull/27359#issuecomment-579486937
Sorry, but it doesn't address my concerns.
> Please check updated description and let me know if that addresses yo
dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update
testthat to >= 2.0.0
URL: https://github.com/apache/spark/pull/27359#issuecomment-578601545
? @zero323 . It seems that you missed my point. I advised like the following.
> I'd like to recommend you to mention
dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update
testthat to >= 2.0.0
URL: https://github.com/apache/spark/pull/27359#issuecomment-578573228
We cannot say `We're good` when we know something wrong. I'd like to
recommend you to mention what you've done clearly.
dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update
testthat to >= 2.0.0
URL: https://github.com/apache/spark/pull/27359#issuecomment-578569365
@zero323 . Thank you for the screencast. However, it skipped all arrow
related tests.
-
dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update
testthat to >= 2.0.0
URL: https://github.com/apache/spark/pull/27359#issuecomment-578473355
@zero323 . Please update the PR description. For example, the followings?
```
Disables unit tests for faulty code (
