[GitHub] [spark] dongjoon-hyun commented on pull request #29044: [SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

2020-07-30 Thread GitBox
dongjoon-hyun commented on pull request #29044: URL: https://github.com/apache/spark/pull/29044#issuecomment-666418050 Thank you all. I see that this passed the GitHub Action at 4589e1b . This is an automated message from

[GitHub] [spark] dongjoon-hyun commented on pull request #29044: [SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

2020-07-10 Thread GitBox
dongjoon-hyun commented on pull request #29044: URL: https://github.com/apache/spark/pull/29044#issuecomment-656758003 It's directly relevant to this PR because your patch is changing `environment` variable. - Please see this for the detail (https://github.com/cdarlint/winutils) -

[GitHub] [spark] dongjoon-hyun commented on pull request #29044: [SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

2020-07-09 Thread GitBox
dongjoon-hyun commented on pull request #29044: URL: https://github.com/apache/spark/pull/29044#issuecomment-656298594 @warrenzhu25 As you see, we have a `Windows OS` test job in AppVeyor. This patch consistently fails there. Could you take a look at that? -

[GitHub] [spark] dongjoon-hyun commented on pull request #29044: [SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

2020-07-08 Thread GitBox
dongjoon-hyun commented on pull request #29044: URL: https://github.com/apache/spark/pull/29044#issuecomment-655622722 @warrenzhu25 . Could you elaborate about what is the regression you are mentioning here? > Fix regression bug in load-spark-env.cmd with Spark 3.0.0

[GitHub] [spark] dongjoon-hyun commented on pull request #29044: [SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

2020-07-08 Thread GitBox
dongjoon-hyun commented on pull request #29044: URL: https://github.com/apache/spark/pull/29044#issuecomment-655622274 cc @srowen This is an automated message from the Apache Git Service. To respond to the message, please