[GitHub] [spark] dongjoon-hyun commented on pull request #35493: [SPAPRK-38192][CORE][TESTS] Use `try-with-resources` in `Level/RocksDBSuite.java`

2022-02-13 Thread GitBox
dongjoon-hyun commented on pull request #35493: URL: https://github.com/apache/spark/pull/35493#issuecomment-1037488781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] dongjoon-hyun commented on pull request #35493: [SPAPRK-38192][CORE][TESTS] Use `try-with-resources` in `Level/RocksDBSuite.java`

2022-02-12 Thread GitBox
dongjoon-hyun commented on pull request #35493: URL: https://github.com/apache/spark/pull/35493#issuecomment-1037711044 Got it. Let me dig it more from my side. Thank you always. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun commented on pull request #35493: [SPAPRK-38192][CORE][TESTS] Use `try-with-resources` in `Level/RocksDBSuite.java`

2022-02-12 Thread GitBox
dongjoon-hyun commented on pull request #35493: URL: https://github.com/apache/spark/pull/35493#issuecomment-1037488781 @LuciferYang . When you describe an issue, you had better put a bigger one first. For example, `LevelDB*.java` was added via SPARK-20641 at Apache Spark 2.3.0 and

[GitHub] [spark] dongjoon-hyun commented on pull request #35493: [SPAPRK-38192][CORE][TESTS] Use `try-with-resources` in `Level/RocksDBSuite.java`

2022-02-11 Thread GitBox
dongjoon-hyun commented on pull request #35493: URL: https://github.com/apache/spark/pull/35493#issuecomment-1036918282 Thank you for update. Please make the PR description up-to-date too. -- This is an automated message from the Apache Git Service. To respond to the message, please log