[GitHub] [spark] dongjoon-hyun commented on pull request #41472: [SPARK-43976][CORE] Handle the case where modifiedConfigs doesn't exist in event logs

2023-06-06 Thread via GitHub
dongjoon-hyun commented on PR #41472: URL: https://github.com/apache/spark/pull/41472#issuecomment-1579355009 Thank you, @viirya . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] dongjoon-hyun commented on pull request #41472: [SPARK-43976][CORE] Handle the case where modifiedConfigs doesn't exist in event logs

2023-06-06 Thread via GitHub
dongjoon-hyun commented on PR #41472: URL: https://github.com/apache/spark/pull/41472#issuecomment-1579098191 Let me merge this. I believe this prevents NPEs from all generated cases ultimately. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun commented on pull request #41472: [SPARK-43976][CORE] Handle the case where modifiedConfigs doesn't exist in event logs

2023-06-06 Thread via GitHub
dongjoon-hyun commented on PR #41472: URL: https://github.com/apache/spark/pull/41472#issuecomment-1579096582 Got it. I double-checked and found more usages ``` $ git grep '\.modifiedConfigs' | grep -v test | grep -v sessionState

[GitHub] [spark] dongjoon-hyun commented on pull request #41472: [SPARK-43976][CORE] Handle the case where modifiedConfigs doesn't exist in event logs

2023-06-06 Thread via GitHub
dongjoon-hyun commented on PR #41472: URL: https://github.com/apache/spark/pull/41472#issuecomment-1578376338 The error happens during loading the old event logs and I'm trying to avoid touching `Store` layers. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] dongjoon-hyun commented on pull request #41472: [SPARK-43976][CORE] Handle the case where modifiedConfigs doesn't exist in event logs

2023-06-06 Thread via GitHub
dongjoon-hyun commented on PR #41472: URL: https://github.com/apache/spark/pull/41472#issuecomment-1578367631 Thank you for review, @MaxGekk . Do you mean here?

[GitHub] [spark] dongjoon-hyun commented on pull request #41472: [SPARK-43976][CORE] Handle the case where modifiedConfigs doesn't exist in event logs

2023-06-06 Thread via GitHub
dongjoon-hyun commented on PR #41472: URL: https://github.com/apache/spark/pull/41472#issuecomment-1577967103 Could you review this when you have some time, please, @viirya ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] dongjoon-hyun commented on pull request #41472: [SPARK-43976][CORE] Handle the case where modifiedConfigs doesn't exist in event logs

2023-06-05 Thread via GitHub
dongjoon-hyun commented on PR #41472: URL: https://github.com/apache/spark/pull/41472#issuecomment-1577837481 Thank you, @ulysses-you . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] dongjoon-hyun commented on pull request #41472: [SPARK-43976][CORE] Handle the case where modifiedConfigs doesn't exist in event logs

2023-06-05 Thread via GitHub
dongjoon-hyun commented on PR #41472: URL: https://github.com/apache/spark/pull/41472#issuecomment-1577832420 cc @HyukjinKwon and @gengliangwang and @ulysses-you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the