[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r871723562 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/numberFormatExpressions.scala: ## @@ -168,3 +168,159 @@ case class TryToNumber(left:

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r871723101 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -599,4 +614,250 @@ class ToNumberParser(numberFormat: String,

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r871722008 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -599,4 +614,250 @@ class ToNumberParser(numberFormat: String,

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r870575731 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala: ## @@ -1108,6 +1125,366 @@ class StringExpressionsSuite extends

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r870575731 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala: ## @@ -1108,6 +1125,366 @@ class StringExpressionsSuite extends

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r870553995 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala: ## @@ -1108,6 +1125,366 @@ class StringExpressionsSuite extends

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r870547232 ## sql/core/src/test/resources/sql-functions/sql-expression-schema.md: ## @@ -1,4 +1,8 @@ +## Summary Review Comment: Nice, thanks for fixing that! It will make

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r870545641 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala: ## @@ -1108,6 +1125,366 @@ class StringExpressionsSuite extends

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r869451006 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -599,4 +614,254 @@ class ToNumberParser(numberFormat: String,

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r869446412 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -599,4 +614,254 @@ class ToNumberParser(numberFormat: String,

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r869446412 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -599,4 +614,254 @@ class ToNumberParser(numberFormat: String,

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r869445021 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -599,4 +614,254 @@ class ToNumberParser(numberFormat: String,

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r869442125 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -599,4 +614,254 @@ class ToNumberParser(numberFormat: String,

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r869441379 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -599,4 +614,254 @@ class ToNumberParser(numberFormat: String,

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r868397971 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/numberFormatExpressions.scala: ## @@ -168,3 +168,157 @@ case class TryToNumber(left:

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r868397446 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/numberFormatExpressions.scala: ## @@ -168,3 +168,157 @@ case class TryToNumber(left:

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r868396911 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/numberFormatExpressions.scala: ## @@ -168,3 +168,157 @@ case class TryToNumber(left:

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r861220757 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala: ## @@ -1108,6 +1125,238 @@ class StringExpressionsSuite extends

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r861219525 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala: ## @@ -1108,6 +1125,238 @@ class StringExpressionsSuite extends

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r861218799 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala: ## @@ -1108,6 +1125,238 @@ class StringExpressionsSuite extends

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r861217041 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala: ## @@ -1108,6 +1125,238 @@ class StringExpressionsSuite extends

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r861215433 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -599,4 +617,240 @@ class ToNumberParser(numberFormat: String,

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r861186496 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala: ## @@ -1108,6 +1125,238 @@ class StringExpressionsSuite extends

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r861186164 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -599,4 +617,240 @@ class ToNumberParser(numberFormat: String,

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r861181335 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -599,4 +617,240 @@ class ToNumberParser(numberFormat: String,

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r861170782 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -599,4 +617,240 @@ class ToNumberParser(numberFormat: String,

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r861164996 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -165,6 +166,10 @@ class ToNumberParser(numberFormat: String, errorOnFail:

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r861164996 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -165,6 +166,10 @@ class ToNumberParser(numberFormat: String, errorOnFail:

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r861163608 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/numberFormatExpressions.scala: ## @@ -168,3 +168,142 @@ case class TryToNumber(left:

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r860053078 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -599,4 +612,227 @@ class ToNumberParser(numberFormat: String,

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r860009328 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -599,4 +612,227 @@ class ToNumberParser(numberFormat: String,

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r859992812 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ToNumberParser.scala: ## @@ -599,4 +612,227 @@ class ToNumberParser(numberFormat: String,

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r859978460 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/numberFormatExpressions.scala: ## @@ -168,3 +168,141 @@ case class TryToNumber(left:

[GitHub] [spark] dtenedor commented on a diff in pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

dtenedor commented on code in PR #36365: URL: https://github.com/apache/spark/pull/36365#discussion_r859976824 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/numberFormatExpressions.scala: ## @@ -168,3 +168,141 @@ case class TryToNumber(left: