dtenedor commented on PR #40449:
URL: https://github.com/apache/spark/pull/40449#issuecomment-1476470933
Looks like some extra tests got added just as this was getting merged!
Thanks @LuciferYang for this fix
--
This is an automated message from the Apache Git Service.
To respond to
dtenedor commented on PR #40449:
URL: https://github.com/apache/spark/pull/40449#issuecomment-1470971482
@gengliangwang alright I made this change, please look again when you are
ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dtenedor commented on PR #40449:
URL: https://github.com/apache/spark/pull/40449#issuecomment-1470824639
@gengliangwang from past experience we will want to keep the query plans
separate from the SQL results, otherwise the SQL results become hard to read. I
will put the analyzer results in
dtenedor commented on PR #40449:
URL: https://github.com/apache/spark/pull/40449#issuecomment-1470823193
@gengliangwang Sure, I was thinking about this too. We can reuse the same
input SQL query files if we want, and just generate and test against different
analyzer test output files. Let
dtenedor commented on PR #40449:
URL: https://github.com/apache/spark/pull/40449#issuecomment-1470712114
Hi @gengliangwang this should be ready for a first look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
