[GitHub] [spark] erenavsarogullari commented on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API

2020-05-07 Thread GitBox
erenavsarogullari commented on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-625574953 Also, i think this PR can be useful for the community as part of `v3.0.0` in addition to `v3.1.0` (current jira affects version points `v3.1.0`). WDYT? --

[GitHub] [spark] erenavsarogullari commented on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API

2020-05-07 Thread GitBox
erenavsarogullari commented on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-625569721 > > @gengliangwang There is optional Http parameter: details (default: false). It needs to be set in order to fetch node, edge and planDescription details as well:

[GitHub] [spark] erenavsarogullari commented on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API

2020-05-07 Thread GitBox
erenavsarogullari commented on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-625569445 > > @gengliangwang There is optional Http parameter: details (default: false). It needs to be set in order to fetch node, edge and planDescription details as well:

[GitHub] [spark] erenavsarogullari commented on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API

2020-05-05 Thread GitBox
erenavsarogullari commented on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-624435102 @gengliangwang There is optional http parameter: `details` (default: `false`). It needs to be set in order to fetch `node`, `edge` and `planDescription` details as wel

[GitHub] [spark] erenavsarogullari commented on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API

2020-05-02 Thread GitBox
erenavsarogullari commented on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-623025795 retest this please This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] erenavsarogullari commented on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API

2020-05-01 Thread GitBox
erenavsarogullari commented on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-622683515 Hi @gengliangwang Thanks one more time for the review. 1- Added `edges` support, 2- Renamed `metricsDetails` as `nodes`, 3- Details are being comput

[GitHub] [spark] erenavsarogullari commented on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API

2020-04-26 Thread GitBox
erenavsarogullari commented on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-619658674 Hi @gengliangwang, Thanks again for the review. Currently, all `nodes` are being listed where `edges` infos as previous attached screenshot. Please let me know if yo