[GitHub] [spark] francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery

2019-05-23 Thread GitBox
francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery URL: https://github.com/apache/spark/pull/24344#issuecomment-495452114 So I'm closing this now, and open another ticket for semi/anti join optimization.

[GitHub] [spark] francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery

2019-05-23 Thread GitBox
francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery URL: https://github.com/apache/spark/pull/24344#issuecomment-495108399 Thanks @dilipbiswal @cloud-fan . I'm ok for trying these, just wanna make contributions to the project. But I think

[GitHub] [spark] francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery

2019-05-22 Thread GitBox
francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery URL: https://github.com/apache/spark/pull/24344#issuecomment-494676914 retest this please This is an automated message from

[GitHub] [spark] francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery

2019-05-20 Thread GitBox
francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery URL: https://github.com/apache/spark/pull/24344#issuecomment-494249369 I'm not sure who is familiar with this, could we ping other reviewers? cc @cloud-fan, @viirya, @dilipbiswal

[GitHub] [spark] francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery

2019-05-15 Thread GitBox
francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery URL: https://github.com/apache/spark/pull/24344#issuecomment-492895116 cc @cloud-fan This is an automated message from the

[GitHub] [spark] francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery

2019-04-27 Thread GitBox
francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery URL: https://github.com/apache/spark/pull/24344#issuecomment-487329532 cc @cloud-fan @viirya @dilipbiswal This is an

[GitHub] [spark] francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery

2019-04-25 Thread GitBox
francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery URL: https://github.com/apache/spark/pull/24344#issuecomment-486619453 I have made some tests in MySQL and SQLServer, and both have the same result with PostgreSQL. I think we'd

[GitHub] [spark] francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery

2019-04-24 Thread GitBox
francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery URL: https://github.com/apache/spark/pull/24344#issuecomment-486334094 Hard to find a SQL spec :( But the document I referenced

[GitHub] [spark] francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery

2019-04-23 Thread GitBox
francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery URL: https://github.com/apache/spark/pull/24344#issuecomment-485714371 I'm still working on this. When I was dealing with 'null' with `InSubquery`, I found something wrong. In

[GitHub] [spark] francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery

2019-04-19 Thread GitBox
francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery URL: https://github.com/apache/spark/pull/24344#issuecomment-485061390 I add several unit tests for both single-column IN subquery and multi-column IN subquery. I didn't test `NOT IN`

[GitHub] [spark] francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery

2019-04-16 Thread GitBox
francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery URL: https://github.com/apache/spark/pull/24344#issuecomment-483660947 Yes, I'm trying to add a physical plan for non-correlated IN now, and will update this PR soon.

[GitHub] [spark] francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery

2019-04-16 Thread GitBox
francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery URL: https://github.com/apache/spark/pull/24344#issuecomment-483642974 I remember that for `InSubquery`, we do not distinguish NULL from FALSE subquery results currently. Here is an

[GitHub] [spark] francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery

2019-04-15 Thread GitBox
francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery URL: https://github.com/apache/spark/pull/24344#issuecomment-483302729 > how about (a, b) in (select c, d ...)? How do we convert it? > If there is no other SQL system doing it, maybe it's

[GitHub] [spark] francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery

2019-04-15 Thread GitBox
francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery URL: https://github.com/apache/spark/pull/24344#issuecomment-483272960 Hi, I'm back with some ideas. I have not found any SQL system that implements the conversion. But IMO, this method

[GitHub] [spark] francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery

2019-04-11 Thread GitBox
francis0407 commented on issue #24344: [SPARK-27440][SQL] Optimize uncorrelated predicate subquery URL: https://github.com/apache/spark/pull/24344#issuecomment-482066270 cc @cloud-fan @maropu @dongjoon-hyun This is an