[GitHub] [spark] frgomes commented on pull request #24969: [SPARK-28151][SQL] Fix MsSqlServerDialect Byte/Short/Float type mappings ( DRAFT)

2020-07-07 Thread GitBox
frgomes commented on pull request #24969: URL: https://github.com/apache/spark/pull/24969#issuecomment-654809859 @srowen : Feedback: As suspected, the issue was between the keyboard and the chair. Maybe I was not casting properly, or maybe a typo or maybe some equality test somewhere...

[GitHub] [spark] frgomes commented on pull request #24969: [SPARK-28151][SQL] Fix MsSqlServerDialect Byte/Short/Float type mappings ( DRAFT)

2020-07-07 Thread GitBox
frgomes commented on pull request #24969: URL: https://github.com/apache/spark/pull/24969#issuecomment-654801380 @srowen :: #25146 only covers ShortType (smallint) and FloatType (real). TinyType (tinyint) seems to be covered here and only here. However, I'm facing an issue which makes be

[GitHub] [spark] frgomes commented on pull request #24969: [SPARK-28151][SQL] Fix MsSqlServerDialect Byte/Short/Float type mappings ( DRAFT)

2020-07-07 Thread GitBox
frgomes commented on pull request #24969: URL: https://github.com/apache/spark/pull/24969#issuecomment-654784071 @srowen : Thanks This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] frgomes commented on pull request #24969: [SPARK-28151][SQL] Fix MsSqlServerDialect Byte/Short/Float type mappings ( DRAFT)

2020-07-07 Thread GitBox
frgomes commented on pull request #24969: URL: https://github.com/apache/spark/pull/24969#issuecomment-654781496 @dongjoon-hyun :: I'm getting this exception below which makes me consider that maybe your fix was not applied. com.microsoft.sqlserver.jdbc.SQLServerException:

[GitHub] [spark] frgomes commented on pull request #24969: [SPARK-28151][SQL] Fix MsSqlServerDialect Byte/Short/Float type mappings ( DRAFT)

2020-07-07 Thread GitBox
frgomes commented on pull request #24969: URL: https://github.com/apache/spark/pull/24969#issuecomment-654777950 @shivsood Hi, what is the PR for ByteType, please? This is an automated message from the Apache Git Service. To