[GitHub] [spark] gengliangwang commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-26 Thread GitBox
gengliangwang commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r757386764 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala ## @@ -1012,6 +1012,194 @@ abstract class CSVSu

[GitHub] [spark] gengliangwang commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-24 Thread GitBox
gengliangwang commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r756567608 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala ## @@ -164,6 +164,10 @@ class CSVOptions( s"${D

[GitHub] [spark] gengliangwang commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-23 Thread GitBox
gengliangwang commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r755249223 ## File path: sql/core/src/test/resources/sql-tests/results/timestampNTZ/timestamp.sql.out ## @@ -373,17 +374,19 @@ structhttps://user-images.githu

[GitHub] [spark] gengliangwang commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-23 Thread GitBox
gengliangwang commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r754907789 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala ## @@ -66,10 +68,23 @@ sealed trait Timestamp

[GitHub] [spark] gengliangwang commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-23 Thread GitBox
gengliangwang commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r754904724 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -442,17 +442,22 @@ object DateTimeUtils {

[GitHub] [spark] gengliangwang commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-23 Thread GitBox
gengliangwang commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r754901303 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala ## @@ -164,6 +164,10 @@ class CSVOptions( s"${D

[GitHub] [spark] gengliangwang commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
gengliangwang commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r752188950 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala ## @@ -1012,6 +1012,162 @@ abstract class CSVSu

[GitHub] [spark] gengliangwang commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
gengliangwang commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r752176600 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchema.scala ## @@ -160,6 +169,15 @@ class CSVInferSchema(val o

[GitHub] [spark] gengliangwang commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-17 Thread GitBox
gengliangwang commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r751887918 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala ## @@ -1012,6 +1012,162 @@ abstract class CSVSu

[GitHub] [spark] gengliangwang commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-17 Thread GitBox
gengliangwang commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r751881590 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala ## @@ -191,6 +212,13 @@ class DefaultTimestam

[GitHub] [spark] gengliangwang commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-17 Thread GitBox
gengliangwang commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r751881376 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala ## @@ -127,6 +140,14 @@ class Iso8601Timestam

[GitHub] [spark] gengliangwang commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-17 Thread GitBox
gengliangwang commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r751867106 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala ## @@ -164,6 +164,20 @@ class CSVOptions( s"${D

[GitHub] [spark] gengliangwang commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-17 Thread GitBox
gengliangwang commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r751867058 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala ## @@ -164,6 +164,20 @@ class CSVOptions( s"${D

[GitHub] [spark] gengliangwang commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-17 Thread GitBox
gengliangwang commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r751861096 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchema.scala ## @@ -160,6 +169,15 @@ class CSVInferSchema(val o

[GitHub] [spark] gengliangwang commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-17 Thread GitBox
gengliangwang commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r751860335 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchema.scala ## @@ -160,6 +169,15 @@ class CSVInferSchema(val o