[GitHub] [spark] gengliangwang commented on a diff in pull request #38513: [SPARK-40903][SQL][FOLLOWUP] Cast canonicalized Add as its original data type if necessary

2022-11-06 Thread GitBox
gengliangwang commented on code in PR #38513: URL: https://github.com/apache/spark/pull/38513#discussion_r101535 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -481,12 +481,12 @@ case class Add( // TODO: do not reorder c

[GitHub] [spark] gengliangwang commented on a diff in pull request #38513: [SPARK-40903][SQL][FOLLOWUP] Cast canonicalized Add as its original data type if necessary

2022-11-06 Thread GitBox
gengliangwang commented on code in PR #38513: URL: https://github.com/apache/spark/pull/38513#discussion_r1014999188 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -481,12 +481,12 @@ case class Add( // TODO: do not reorder c