[GitHub] [spark] gengliangwang commented on a diff in pull request #39682: [SPARK-42139][CORE][SQL] Handle null string values in SQLExecutionUIData/SparkPlanGraphWrapper/SQLPlanMetric

2023-01-21 Thread via GitHub
gengliangwang commented on code in PR #39682: URL: https://github.com/apache/spark/pull/39682#discussion_r1083262127 ## sql/core/src/main/scala/org/apache/spark/status/protobuf/sql/SQLExecutionUIDataSerializer.scala: ## @@ -23,17 +23,17 @@ import collection.JavaConverters._ i

[GitHub] [spark] gengliangwang commented on a diff in pull request #39682: [SPARK-42139][CORE][SQL] Handle null string values in SQLExecutionUIData/SparkPlanGraphWrapper/SQLPlanMetric

2023-01-20 Thread via GitHub
gengliangwang commented on code in PR #39682: URL: https://github.com/apache/spark/pull/39682#discussion_r1083255761 ## sql/core/src/test/scala/org/apache/spark/status/protobuf/sql/KVStoreProtobufSerializerSuite.scala: ## @@ -48,6 +48,43 @@ class KVStoreProtobufSerializerSuite e

[GitHub] [spark] gengliangwang commented on a diff in pull request #39682: [SPARK-42139][CORE][SQL] Handle null string values in SQLExecutionUIData/SparkPlanGraphWrapper/SQLPlanMetric

2023-01-20 Thread via GitHub
gengliangwang commented on code in PR #39682: URL: https://github.com/apache/spark/pull/39682#discussion_r1083255631 ## sql/core/src/main/scala/org/apache/spark/status/protobuf/sql/SQLPlanMetricSerializer.scala: ## @@ -19,18 +19,24 @@ package org.apache.spark.status.protobuf.sql