[GitHub] [spark] gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-26 Thread GitBox
gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558859295 I will merge it once jenkins test passes. This is an automated message from

[GitHub] [spark] gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-26 Thread GitBox
gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558831120 @HeartSaVioR I have updated the PR description from ``` We found a bug on SPARK-26081 and SPARK-2 was proposed to fix it, but we

[GitHub] [spark] gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-26 Thread GitBox
gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558783691 @HeartSaVioR Please update the PR description with more details This is an

[GitHub] [spark] gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-26 Thread GitBox
gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558746552 > now we at least write one file for each partition? No, in DSV1, only partition 0 will write empty file:

[GitHub] [spark] gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558488299 OK, I think the current PR is good :) This is an automated message from the

[GitHub] [spark] gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558458791 @HeartSaVioR the file `CsvOutputWriter.scala` was moved in another PR, and this PR is **not directly reverting** from the original commit.

[GitHub] [spark] gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558448838 Well I was expecting this PR comes with UTs... @dongjoon-hyun @gatorsmile @zsxwing WDYT?