[GitHub] [spark] gengliangwang commented on pull request #40449: [SPARK-42791][SQL] Create a new golden file test framework for analysis

gengliangwang commented on PR #40449: URL: https://github.com/apache/spark/pull/40449#issuecomment-1472785577 LGTM except for minor comments. Thanks for the work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] gengliangwang commented on pull request #40449: [SPARK-42791][SQL] Create a new golden file test framework for analysis

gengliangwang commented on PR #40449: URL: https://github.com/apache/spark/pull/40449#issuecomment-1470835260 > I will put the analyzer results in separate files. Sounds great! Thanks for the work! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] gengliangwang commented on pull request #40449: [SPARK-42791][SQL] Create a new golden file test framework for analysis

gengliangwang commented on PR #40449: URL: https://github.com/apache/spark/pull/40449#issuecomment-1470801546 @dtenedor Since we already have `SQLQueryTestSuite` which has good basic Spark SQL features coverage, shall we combine both? E.g. let `SQLQueryTestSuite` show analyzed