[GitHub] [spark] holdenk commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

holdenk commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-673061873 Gotcha, I've got those two changes in now and I'll see how it goes in Jenkins/GHA :) Just an FYI to other folks since there are no outstanding blockers I intend to merge this

[GitHub] [spark] holdenk commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

holdenk commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-673051361 Just to be clear what's the outstanding blocker in your opinion? This is an automated message from the Apache

[GitHub] [spark] holdenk commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

holdenk commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-671610963 (I'll also try and go through and resolve the old comments tonight). This is an automated message from the

[GitHub] [spark] holdenk commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

holdenk commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-671609996 Sorry I'm dealing with some other things so I only had the cycles to do a partial response to the comments. I'll try and get back to them tonight or tomorrow.

[GitHub] [spark] holdenk commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

holdenk commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-670292989 I'm taking the next few days off (Friday-Sunday), I'll take another poke at this on Monday :) This is an

[GitHub] [spark] holdenk commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

holdenk commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-670201860 I _think_ the javadoc failure in GHA is unrelated, I'll rebase this in a bit (I can't reproduce locally though).

[GitHub] [spark] holdenk commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

holdenk commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-669665636 > @holdenk, I am a bit confused by the commit message of the only commit in this PR: "Shutdown executor once we are done decommissioning". Isn't this the recently merged PR

[GitHub] [spark] holdenk commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

holdenk commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-669615542 cc @cloud-fan who asked about the progress on a related PR in case he is interested. This is an automated

[GitHub] [spark] holdenk commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

holdenk commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-669615038 cc @attilapiros & @agrawaldevesh This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] holdenk commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

holdenk commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-669614811 This is a rebase of https://github.com/apache/spark/pull/28818 now that its pre-requisites have been merged.