[GitHub] [spark] holdenk commented on pull request #37556: [SPARK-39799][SQL] DataSourceV2: View catalog interface

2022-11-16 Thread GitBox
holdenk commented on PR #37556: URL: https://github.com/apache/spark/pull/37556#issuecomment-1317352658 LGTM I'll merge this now to the current dev branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] holdenk commented on pull request #37556: [SPARK-39799][SQL] DataSourceV2: View catalog interface

2022-11-02 Thread GitBox
holdenk commented on PR #37556: URL: https://github.com/apache/spark/pull/37556#issuecomment-1301564329 pending CI and any other concerns I plan to merge this on Friday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] holdenk commented on pull request #37556: [SPARK-39799][SQL] DataSourceV2: View catalog interface

2022-08-22 Thread GitBox
holdenk commented on PR #37556: URL: https://github.com/apache/spark/pull/37556#issuecomment-1223246102 Interesting, the failure in `CliSuite` seems like a red-herring (e.g. that text is present), maybe try a re-base + re-run? -- This is an automated message from the Apache Git Service.

[GitHub] [spark] holdenk commented on pull request #37556: [SPARK-39799][SQL] DataSourceV2: View catalog interface

2022-08-18 Thread GitBox
holdenk commented on PR #37556: URL: https://github.com/apache/spark/pull/37556#issuecomment-1219780843 cc @dongjoon-hyun who had comments on the SPIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to