[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-04 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r465203303 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -184,15 +189,62 @@ abstract class JdbcDialect extends Serializa

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-03 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464825759 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -184,15 +189,62 @@ abstract class JdbcDialect extends Serializa

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-03 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464697692 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala ## @@ -106,4 +106,84 @@ class JDBC

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-03 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464814466 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -184,15 +189,62 @@ abstract class JdbcDialect extends Serializa

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-03 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464814358 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala ## @@ -900,10 +889,52 @@ object JdbcUtils extends

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-03 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464698718 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala ## @@ -900,10 +889,41 @@ object JdbcUtils extends

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-03 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464697692 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala ## @@ -106,4 +106,84 @@ class JDBC

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-03 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464697545 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala ## @@ -106,4 +106,84 @@ class JDBC

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-03 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464697039 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -184,15 +189,62 @@ abstract class JdbcDialect extends Serializa

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-03 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464241595 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -184,15 +189,65 @@ abstract class JdbcDialect extends Serializa

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464022034 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala ## @@ -908,4 +909,25 @@ object JdbcUtils extends

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464021800 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -184,15 +189,56 @@ abstract class JdbcDialect extends Serializa

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464020918 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -184,15 +189,56 @@ abstract class JdbcDialect extends Serializa

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464020845 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -184,15 +189,56 @@ abstract class JdbcDialect extends Serializa

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-07-31 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r463926557 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -184,15 +189,56 @@ abstract class JdbcDialect extends Serializa

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-07-31 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r463898878 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala ## @@ -908,4 +909,25 @@ object JdbcUtils extends