huaxingao commented on issue #27570: [SPARK-30820][SPARKR][ML] Add FMClassifier
to SparkR
URL: https://github.com/apache/spark/pull/27570#issuecomment-594876824
retest this please
This is an automated message from the Apache
huaxingao commented on issue #27570: [SPARK-30820][SPARKR][ML] Add FMClassifier
to SparkR
URL: https://github.com/apache/spark/pull/27570#issuecomment-594793567
retest this please
This is an automated message from the Apache
huaxingao commented on issue #27570: [SPARK-30820][SPARKR][ML] Add FMClassifier
to SparkR
URL: https://github.com/apache/spark/pull/27570#issuecomment-594682827
LGTM
@zero323 You may want to delete the dir using ```unlink(modelPath)``` after
testing model save/load, and delete the
huaxingao commented on issue #27570: [SPARK-30820][SPARKR][ML] Add FMClassifier
to SparkR
URL: https://github.com/apache/spark/pull/27570#issuecomment-594337920
retest this please
This is an automated message from the Apache
huaxingao commented on issue #27570: [SPARK-30820][SPARKR][ML] Add FMClassifier
to SparkR
URL: https://github.com/apache/spark/pull/27570#issuecomment-593518323
@zero323 Sorry, one more thing: ```FMClassifier ```currently only supports
binary classification, so the labels must be 0 and 1.
huaxingao commented on issue #27570: [SPARK-30820][SPARKR][ML] Add FMClassifier
to SparkR
URL: https://github.com/apache/spark/pull/27570#issuecomment-593506827
@zero323
I left a couple of more inline comments. I think we are almost there. You
did a good job on this PR. Thanks a lot
huaxingao commented on issue #27570: [SPARK-30820][SPARKR][ML] Add FMClassifier
to SparkR
URL: https://github.com/apache/spark/pull/27570#issuecomment-589248139
@zero323 Could you please add an item for R in FRClassifier section of
ml-classification-regression.md? Please also update
huaxingao commented on issue #27570: [SPARK-30820][SPARKR][ML] Add FMClassifier
to SparkR
URL: https://github.com/apache/spark/pull/27570#issuecomment-587236861
cc @felixcheung
This is an automated message from the Apache
