[GitHub] [spark] hvanhovell commented on pull request #40252: [SPARK-42555][CONNECT] Add JDBC to DataFrameReader

2023-03-03 Thread via GitHub
hvanhovell commented on PR #40252: URL: https://github.com/apache/spark/pull/40252#issuecomment-1454350262 merging to master/3.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] hvanhovell commented on pull request #40252: [SPARK-42555][CONNECT] Add JDBC to DataFrameReader

2023-03-02 Thread via GitHub
hvanhovell commented on PR #40252: URL: https://github.com/apache/spark/pull/40252#issuecomment-1452353820 @beliefer you can create a test in `PlanGenerationTestSuite`. That will at least validate the proto message we are generating, and it will validate that plan you are producing yields