infoankitp commented on PR #38865:
URL: https://github.com/apache/spark/pull/38865#issuecomment-1368871113
> @LuciferYang @zhengruifeng @beliefer @cloud-fan Friendly reminder for
reviewing ! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
infoankitp commented on PR #38865:
URL: https://github.com/apache/spark/pull/38865#issuecomment-1367850300
@LuciferYang @zhengruifeng @beliefer @HyukjinKwon Made the changes. Please
do review once you get chance. Thanks!
--
This is an automated message from the Apache Git Service.
To
infoankitp commented on PR #38865:
URL: https://github.com/apache/spark/pull/38865#issuecomment-1364475818
@beliefer @LuciferYang Rebased the changes again! Please help review and
advise if anything else needs to be done. :)
--
This is an automated message from the Apache Git Service.
infoankitp commented on PR #38865:
URL: https://github.com/apache/spark/pull/38865#issuecomment-1361213881
>
@beliefer Thanks for bringing this to notice. Rebased the branch on recent
master. :) Please do review the changes. Thanks!
--
This is an automated message from the
infoankitp commented on PR #38865:
URL: https://github.com/apache/spark/pull/38865#issuecomment-1358869906
@beliefer @LuciferYang Friendly ping! Please review the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
infoankitp commented on PR #38865:
URL: https://github.com/apache/spark/pull/38865#issuecomment-1354296737
@beliefer Removed the extra variable as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
infoankitp commented on PR #38865:
URL: https://github.com/apache/spark/pull/38865#issuecomment-1353192974
@beliefer Pushed the changes please do review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
infoankitp commented on PR #38865:
URL: https://github.com/apache/spark/pull/38865#issuecomment-1350610550
@LuciferYang @beliefer Removed changes regarding array_prepend function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
infoankitp commented on PR #38865:
URL: https://github.com/apache/spark/pull/38865#issuecomment-1342609183
> > Yes, array_append function will be available in spark sql
>
> Because this function is a new feature, so the answer should be `No`.
Updated again
--
This is an
infoankitp commented on PR #38865:
URL: https://github.com/apache/spark/pull/38865#issuecomment-1342291406
@beliefer I will add more references for similar array_append function soon.
@LuciferYang @zhengruifeng I have made this function more consistent with
other high-order functions as
infoankitp commented on PR #38865:
URL: https://github.com/apache/spark/pull/38865#issuecomment-1342267449
> @infoankitp Could you update the PR description and add the info contains
syntax, arguments, examples and the mainstream database supports array_append ?
Please refer #36708.
infoankitp commented on PR #38865:
URL: https://github.com/apache/spark/pull/38865#issuecomment-1342244189
> One other issue @zhengruifeng @LuciferYang - this is one interesting edge
case:
>
> > > array_insert([1,2,3], 4, null)
> > > [1,2,3,-1]
>
> aka, a null entry for
infoankitp commented on PR #38865:
URL: https://github.com/apache/spark/pull/38865#issuecomment-1339304055
> @infoankitp Would you mind adding some sql related tests to
`sql-tests/inputs/array.sql`?
Added in the recent Commit.
--
This is an automated message from the Apache Git
infoankitp commented on PR #38865:
URL: https://github.com/apache/spark/pull/38865#issuecomment-1339187683
Ran the above command got below output
`SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly
*ExpressionsSchemaSuite"`
```
[info] ExpressionsSchemaSuite:
17:00:33.694
14 matches
Mail list logo
