[GitHub] [spark] itholic commented on pull request #34324: [SPARK-37015][PYTHON] Inline type hints for python/pyspark/streaming/dstream.py

2022-04-18 Thread GitBox
itholic commented on PR #34324: URL: https://github.com/apache/spark/pull/34324#issuecomment-1101934294 Thanks, @dchvn too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [spark] itholic commented on pull request #34324: [SPARK-37015][PYTHON] Inline type hints for python/pyspark/streaming/dstream.py

2022-04-18 Thread GitBox
itholic commented on PR #34324: URL: https://github.com/apache/spark/pull/34324#issuecomment-1101414419 No worries! Thanks for fixing :-) Seems like the test is passed at https://github.com/dchvn/spark/actions/runs/2182508677. -- This is an automated message from the Apache Git

[GitHub] [spark] itholic commented on pull request #34324: [SPARK-37015][PYTHON] Inline type hints for python/pyspark/streaming/dstream.py

2022-04-17 Thread GitBox
itholic commented on PR #34324: URL: https://github.com/apache/spark/pull/34324#issuecomment-1101006522 @dchvn Mind addressing https://github.com/apache/spark/pull/34324#issuecomment-1100179912 ? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] itholic commented on pull request #34324: [SPARK-37015][PYTHON] Inline type hints for python/pyspark/streaming/dstream.py

2022-04-13 Thread GitBox
itholic commented on PR #34324: URL: https://github.com/apache/spark/pull/34324#issuecomment-1098703075 Looks good except the remaining comments. Thanks for your time to contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] itholic commented on pull request #34324: [SPARK-37015][PYTHON] Inline type hints for python/pyspark/streaming/dstream.py

2022-04-10 Thread GitBox
itholic commented on PR #34324: URL: https://github.com/apache/spark/pull/34324#issuecomment-1094569793 No worries!! Thanks for the review, @zero323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] itholic commented on pull request #34324: [SPARK-37015][PYTHON] Inline type hints for python/pyspark/streaming/dstream.py

2022-04-03 Thread GitBox
itholic commented on PR #34324: URL: https://github.com/apache/spark/pull/34324#issuecomment-1087105177 Also mind taking a last look for this, @zero323 ??  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL