[GitHub] [spark] itholic commented on pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020

2023-06-30 Thread via GitHub
itholic commented on PR #39702: URL: https://github.com/apache/spark/pull/39702#issuecomment-1614954337 CI passed. cc @MaxGekk FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] itholic commented on pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020

2023-03-29 Thread via GitHub
itholic commented on PR #39702: URL: https://github.com/apache/spark/pull/39702#issuecomment-1489668136 @MaxGekk Can you take a look when you find some time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] itholic commented on pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020

2023-02-13 Thread via GitHub
itholic commented on PR #39702: URL: https://github.com/apache/spark/pull/39702#issuecomment-1427721497 Gentle reminder for @MaxGekk on previous updates -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] itholic commented on pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020

2023-02-06 Thread via GitHub
itholic commented on PR #39702: URL: https://github.com/apache/spark/pull/39702#issuecomment-1420198767 Updated tests, and also rename the error class as `INVALID_USAGE_OF_STAR_OR_REGEX`, instead if `INVALID_USAGE_OF_STAR` since it also manage the case for invalid usage of regular

[GitHub] [spark] itholic commented on pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020

2023-02-06 Thread via GitHub
itholic commented on PR #39702: URL: https://github.com/apache/spark/pull/39702#issuecomment-1420179550 Oh, seems like they already in `sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala`. Let me update them to use `checkError`. -- This is an

[GitHub] [spark] itholic commented on pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020

2023-01-22 Thread via GitHub
itholic commented on PR #39702: URL: https://github.com/apache/spark/pull/39702#issuecomment-1399797614 cc @MaxGekk @srielau @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the