[GitHub] [spark] itholic commented on pull request #40280: [SPARK-42671][CONNECT] Fix bug for createDataFrame from complex type schema

2023-03-07 Thread via GitHub
itholic commented on PR #40280: URL: https://github.com/apache/spark/pull/40280#issuecomment-1458111230 Awesome!! Let me take a look at your PR. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] itholic commented on pull request #40280: [SPARK-42671][CONNECT] Fix bug for createDataFrame from complex type schema

2023-03-06 Thread via GitHub
itholic commented on PR #40280: URL: https://github.com/apache/spark/pull/40280#issuecomment-1457558427 Thanks, @panbingkun ! By the way, I think this issue has a pretty high priority since the default nullability of a schema is `False`. ```python >>> sdf =

[GitHub] [spark] itholic commented on pull request #40280: [SPARK-42671][CONNECT] Fix bug for createDataFrame from complex type schema

2023-03-05 Thread via GitHub
itholic commented on PR #40280: URL: https://github.com/apache/spark/pull/40280#issuecomment-1455567210 Thanks @panbingkun for the nice fix! Btw, think I found another `createDataFrame` bug which is not working properly with non-nullable schema as below: ```python >>> from

[GitHub] [spark] itholic commented on pull request #40280: [SPARK-42671][CONNECT] Fix bug for createDataFrame from complex type schema

2023-03-05 Thread via GitHub
itholic commented on PR #40280: URL: https://github.com/apache/spark/pull/40280#issuecomment-1455565581 Thanks @panbingkun for the nice fix! Btw, think I found another `createDataFrame` bug which is not working properly with non-nullable schema as below: ```python >>> from