[GitHub] [spark] ivoson commented on a diff in pull request #40286: [SPARK-42577][CORE] Add max attempts limitation for stages to avoid potential infinite retry

2023-03-11 Thread via GitHub
ivoson commented on code in PR #40286: URL: https://github.com/apache/spark/pull/40286#discussion_r1133064529 ## core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala: ## @@ -4572,6 +4572,48 @@ class DAGSchedulerSuite extends SparkFunSuite with

[GitHub] [spark] ivoson commented on a diff in pull request #40286: [SPARK-42577][CORE] Add max attempts limitation for stages to avoid potential infinite retry

2023-03-11 Thread via GitHub
ivoson commented on code in PR #40286: URL: https://github.com/apache/spark/pull/40286#discussion_r1133064501 ## core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala: ## @@ -4572,6 +4572,48 @@ class DAGSchedulerSuite extends SparkFunSuite with

[GitHub] [spark] ivoson commented on a diff in pull request #40286: [SPARK-42577][CORE] Add max attempts limitation for stages to avoid potential infinite retry

2023-03-07 Thread via GitHub
ivoson commented on code in PR #40286: URL: https://github.com/apache/spark/pull/40286#discussion_r1128798692 ## core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala: ## @@ -4572,6 +4572,48 @@ class DAGSchedulerSuite extends SparkFunSuite with

[GitHub] [spark] ivoson commented on a diff in pull request #40286: [SPARK-42577][CORE] Add max attempts limitation for stages to avoid potential infinite retry

2023-03-06 Thread via GitHub
ivoson commented on code in PR #40286: URL: https://github.com/apache/spark/pull/40286#discussion_r1126637185 ## core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala: ## @@ -232,6 +232,13 @@ private[spark] class DAGScheduler(

[GitHub] [spark] ivoson commented on a diff in pull request #40286: [SPARK-42577][CORE] Add max attempts limitation for stages to avoid potential infinite retry

2023-03-06 Thread via GitHub
ivoson commented on code in PR #40286: URL: https://github.com/apache/spark/pull/40286#discussion_r1126636319 ## core/src/main/scala/org/apache/spark/internal/config/package.scala: ## @@ -2479,4 +2479,14 @@ package object config { .version("3.4.0") .booleanConf

[GitHub] [spark] ivoson commented on a diff in pull request #40286: [SPARK-42577][CORE] Add max attempts limitation for stages to avoid potential infinite retry

2023-03-06 Thread via GitHub
ivoson commented on code in PR #40286: URL: https://github.com/apache/spark/pull/40286#discussion_r1126633329 ## core/src/main/scala/org/apache/spark/scheduler/Stage.scala: ## @@ -70,6 +70,7 @@ private[scheduler] abstract class Stage( /** The ID to use for the next new

[GitHub] [spark] ivoson commented on a diff in pull request #40286: [SPARK-42577][CORE] Add max attempts limitation for stages to avoid potential infinite retry

2023-03-06 Thread via GitHub
ivoson commented on code in PR #40286: URL: https://github.com/apache/spark/pull/40286#discussion_r1126616705 ## core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala: ## @@ -406,12 +406,13 @@ class DAGSchedulerSuite extends SparkFunSuite with

[GitHub] [spark] ivoson commented on a diff in pull request #40286: [SPARK-42577][CORE] Add max attempts limitation for stages to avoid potential infinite retry

2023-03-06 Thread via GitHub
ivoson commented on code in PR #40286: URL: https://github.com/apache/spark/pull/40286#discussion_r1126616705 ## core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala: ## @@ -406,12 +406,13 @@ class DAGSchedulerSuite extends SparkFunSuite with