javierivanov opened a new pull request #27498: [SPARK-30688][SQL] Week based dates not being parsed with TimestampFormatter URL: https://github.com/apache/spark/pull/27498 <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html 2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'. 4. Be sure to keep the PR description updated to reflect all changes. 5. Please write your PR title to summarize what this PR proposes. 6. If possible, provide a concise example to reproduce the issue for a faster review. --> ### What changes were proposed in this pull request? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below. 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers. 2. If you fix some SQL features, you can provide some references of other DBMSes. 3. If there is design documentation, please add the link. 4. If there is a discussion in the mailing list, please add the link. --> When executing the following query using a week based pattern the result is null. ``` scala> spark.sql("select unix_timestamp('2020-10', 'YYYY-ww')").show +--------------------------------+ |unix_timestamp(2020-10, YYYY-ww)| +--------------------------------+ | null| +--------------------------------+ ``` You can replicate this behavior with: ``` import java.time.temporal._ import java.time.format._ import java.util.Locale import java.time.chrono.IsoChronology val pattern = "YYYY-ww" val locale = Locale.US val s = "2020-10" val formatter = new DateTimeFormatterBuilder().appendPattern(pattern) .parseDefaulting(ChronoField.ERA, 1) .parseDefaulting(ChronoField.MONTH_OF_YEAR, 1) .parseDefaulting(ChronoField.DAY_OF_MONTH, 1) .parseDefaulting(ChronoField.MINUTE_OF_HOUR, 0) .parseDefaulting(ChronoField.SECOND_OF_MINUTE, 0) .toFormatter(locale) .withChronology(IsoChronology.INSTANCE) .withResolverStyle(ResolverStyle.STRICT) val result = formatter.parse(s) result.query(TemporalQueries.localDate) ``` The date is parsed, but not resolved. This is caused by the default temporal fields that are conflicting with the week based values: ``` .parseDefaulting(ChronoField.ERA, 1) .parseDefaulting(ChronoField.MONTH_OF_YEAR, 1) .parseDefaulting(ChronoField.DAY_OF_MONTH, 1) ``` To avoid this conflict, I propose to check if the pattern is a week/year based and change the defaults as follows: ``` .parseDefaulting(ChronoField.ERA, 1) .parseDefaulting(ChronoField.DAY_OF_WEEK, 1) ``` ### Why are the changes needed? <!-- Please clarify why the changes are needed. For instance, 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. --> Week/Year based dates should be supported since it is part of ISO8601. Also, as seen in [SPARK-30688](https://issues.apache.org/jira/browse/SPARK-30688), this issue is failing silently. ### Does this PR introduce any user-facing change? <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If no, write 'No'. --> - No ### How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> - Passing current tests - Added test case for different timezones in `DateExpressionsSuite.scala`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
