[GitHub] [spark] jiangxb1987 commented on issue #24699: [SPARK-27666][CORE] Do not release lock while TaskContext already completed

2019-06-12 Thread GitBox
jiangxb1987 commented on issue #24699: [SPARK-27666][CORE] Do not release lock while TaskContext already completed URL: https://github.com/apache/spark/pull/24699#issuecomment-501545350 LGTM This is an automated message from

[GitHub] [spark] jiangxb1987 commented on issue #24699: [SPARK-27666][CORE] Do not release lock while TaskContext already completed

2019-05-28 Thread GitBox
jiangxb1987 commented on issue #24699: [SPARK-27666][CORE] Do not release lock while TaskContext already completed URL: https://github.com/apache/spark/pull/24699#issuecomment-496753112 We can go either way, both looks fine to me. I would refactor `releaseLockAndDispose()` further to take

[GitHub] [spark] jiangxb1987 commented on issue #24699: [SPARK-27666][CORE] Do not release lock while TaskContext already completed

2019-05-28 Thread GitBox
jiangxb1987 commented on issue #24699: [SPARK-27666][CORE] Do not release lock while TaskContext already completed URL: https://github.com/apache/spark/pull/24699#issuecomment-496613041 Have you considered change the logic in https://github.com/apache/spark/blob/e9f3f62b2c0f521f3cc23fef381