joveyuan-db opened a new pull request, #39681:
URL: https://github.com/apache/spark/pull/39681

   ### What changes were proposed in this pull request?
   This PR ensures that SparkR serializes `NA` dates as `"NA"` (string) to 
avoid an undefined length when deserializing in the JVM.
   
   ### Why are the changes needed?
   Currently, SparkR assumes that a `NegativeArraySizeException` when 
deserializing dates and timestamps represents an `NA`.  However, this handling 
can be made more robust by ensuring that serialization on the R side always 
provides a valid string length (note that `nchar(as.character(as.Date(NA)))` is 
`NA`).
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions 
for the consistent environment, and the instructions could accord to: 
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to