kbendick opened a new pull request #30244:
URL: https://github.com/apache/spark/pull/30244
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR removes the old Probot Autolabeler labeling configuration, as the
probot autolabeler has been deprecated. I've updated the configs in Iceberg and
in Avro, and we also need to update here. This PR adds in an additional
workflow for labeling PRs and migrates the old probot config to the new format.
Unfortunately, because certain features have not been released upstream, we
will not get the _exact_ behavior as before. I have documented where that is
and what changes are neeeded, and in the associated ticket I've also discussed
other options and why I think this is the best way to go. Definitely a follow
up ticket is needed to get the original behavior back in these few cases, but
PRs have not been labeled for almost a month and so it's probably best to get
it right 95% of the time and occasionally have some UI related PRs labeled as
`CORE` while the issue is resolved upstream and/or further investigated.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The probot autolabeler is dead and will not be maintained going forward.
This has been confirmed with github user [at]mithro in an issue in their
repository.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
By merging into my personal fork and then running a large number of tests.
Unfortunately, I've overwritten my fork with the apache repo in order to
create a proper PR. However, I've also added the config for the same thing in
the Iceberg repo as well as the Avro repo. I can work on adding tests for this,
but I'm pretty swamped this week and the next so either somebody else would
have to take the lead on that, we'd have to wait, or we can just inspect it,
merge it, and then observe what happens as PRs come in. I personally vote for
the latter but thats probably because this is the third one of these I've done
in the `apache` sphere and I admittedly won't have much time to work on it for
another week or so, but I'm happy to make tickets and to let anybody who would
like to take the reins.
I've also discovered that we're likely not killing github actions that run
(like large tests etc) when users push to their PR. In order to save time /
capacity on the runners, we should add an action in each workflow that cancels
old runs when a `push` action occurs on a PR. This will likely make waiting for
test runners much faster, especially if added to all of the workflows in the
Apache account (as github action API limits are set at the account level).
Admittedly, the fact that the "old" workflow runs weren't cancelled could
admittedly be because of the fact that I was working in a fork, but given that
there are explicit actions to be added to the start of workflows to cancel old
PR workflows and given that we don't have them configured indicates to me that
likely this is the case in this repo (and in most `apache` repos as well).
The last Apache repo to still have the probot autolabeler in it is Beam, at
which point we can have Gavin from Infra remove the permissions for the probot
autolabeler entirely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
