[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316303481 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataFrameWriterV2Suite.scala ##

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316294998 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.sca

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316294655 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/PartitionTransforms.scala #

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r315998940 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/PartitionTransforms.scala #

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316012778 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -3942,6 +3943,61 @@ o

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316003794 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.sca

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316224997 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataFrameWriterV2Suite.scala ##

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316226686 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataFrameWriterV2Suite.scala ##

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316006273 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -3178,6 +3178,34 @@ cla