[GitHub] [spark] maropu commented on a change in pull request #25033: [SPARK-28224][SQL] Check overflow in decimal Sum aggregate

2019-08-17 Thread GitBox
maropu commented on a change in pull request #25033: [SPARK-28224][SQL] Check overflow in decimal Sum aggregate URL: https://github.com/apache/spark/pull/25033#discussion_r314962435 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -156,

[GitHub] [spark] maropu commented on a change in pull request #25033: [SPARK-28224][SQL] Check overflow in decimal Sum aggregate

2019-08-17 Thread GitBox
maropu commented on a change in pull request #25033: [SPARK-28224][SQL] Check overflow in decimal Sum aggregate URL: https://github.com/apache/spark/pull/25033#discussion_r314962435 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -156,

[GitHub] [spark] maropu commented on a change in pull request #25033: [SPARK-28224][SQL] Check overflow in decimal Sum aggregate

2019-08-15 Thread GitBox
maropu commented on a change in pull request #25033: [SPARK-28224][SQL] Check overflow in decimal Sum aggregate URL: https://github.com/apache/spark/pull/25033#discussion_r314206647 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -156,

[GitHub] [spark] maropu commented on a change in pull request #25033: [SPARK-28224][SQL] Check overflow in decimal Sum aggregate

2019-08-15 Thread GitBox
maropu commented on a change in pull request #25033: [SPARK-28224][SQL] Check overflow in decimal Sum aggregate URL: https://github.com/apache/spark/pull/25033#discussion_r314205594 ## File path: sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestData.scala ## @@ -91

[GitHub] [spark] maropu commented on a change in pull request #25033: [SPARK-28224][SQL] Check overflow in decimal Sum aggregate

2019-08-15 Thread GitBox
maropu commented on a change in pull request #25033: [SPARK-28224][SQL] Check overflow in decimal Sum aggregate URL: https://github.com/apache/spark/pull/25033#discussion_r314204706 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -156,