maropu commented on a change in pull request #28654:
URL: https://github.com/apache/spark/pull/28654#discussion_r432178411
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeWriteCompatibilitySuite.scala
##########
@@ -80,7 +80,7 @@ class StrictDataTypeWriteCompatibilitySuite extends
DataTypeWriteCompatibilityBa
test("Check NullType is incompatible with all other types") {
allNonNullTypes.foreach { t =>
assertSingleError(NullType, t, "nulls", s"Should not allow writing None
to type $t") { err =>
- assert(err.contains(s"incompatible with $t"))
+ assert(err.contains(s"incompatible with ${t.simpleString}"))
Review comment:
nit `catalogString`, too?
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeWriteCompatibilitySuite.scala
##########
@@ -209,8 +209,8 @@ abstract class DataTypeWriteCompatibilityBaseSuite extends
SparkFunSuite {
s"Should not allow writing $w to $r because cast is not safe") {
err =>
assert(err.contains("'t'"), "Should include the field name
context")
assert(err.contains("Cannot safely cast"), "Should identify unsafe
cast")
- assert(err.contains(s"$w"), "Should include write type")
- assert(err.contains(s"$r"), "Should include read type")
+ assert(err.contains(s"${w.simpleString}"), "Should include write
type")
+ assert(err.contains(s"${r.simpleString}"), "Should include read
type")
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
