[GitHub] [spark] maropu commented on a change in pull request #29054: [SPARK-32243][SQL]HiveSessionCatalog call super.makeFunctionExpression should show error message

2020-07-10 Thread GitBox
maropu commented on a change in pull request #29054: URL: https://github.com/apache/spark/pull/29054#discussion_r452758095 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ## @@ -69,49 +69,56 @@ private[sql] class HiveSessionCatalog(

[GitHub] [spark] maropu commented on a change in pull request #29054: [SPARK-32243][SQL]HiveSessionCatalog call super.makeFunctionExpression should show error message

2020-07-09 Thread GitBox
maropu commented on a change in pull request #29054: URL: https://github.com/apache/spark/pull/29054#discussion_r452627861 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDAFSuite.scala ## @@ -161,6 +161,21 @@ class HiveUDAFSuite extends

[GitHub] [spark] maropu commented on a change in pull request #29054: [SPARK-32243][SQL]HiveSessionCatalog call super.makeFunctionExpression should show error message

2020-07-09 Thread GitBox
maropu commented on a change in pull request #29054: URL: https://github.com/apache/spark/pull/29054#discussion_r452627431 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ## @@ -69,49 +69,56 @@ private[sql] class HiveSessionCatalog(