[GitHub] [spark] maropu commented on a change in pull request #29828: [SPARK-32948][SQL] Optimize to_json and from_json expression chain

2020-09-25 Thread GitBox
maropu commented on a change in pull request #29828: URL: https://github.com/apache/spark/pull/29828#discussion_r494010395 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JsonSuite.scala ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache

[GitHub] [spark] maropu commented on a change in pull request #29828: [SPARK-32948][SQL] Optimize to_json and from_json expression chain

2020-09-23 Thread GitBox
maropu commented on a change in pull request #29828: URL: https://github.com/apache/spark/pull/29828#discussion_r494010395 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JsonSuite.scala ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache

[GitHub] [spark] maropu commented on a change in pull request #29828: [SPARK-32948][SQL] Optimize to_json and from_json expression chain

2020-09-22 Thread GitBox
maropu commented on a change in pull request #29828: URL: https://github.com/apache/spark/pull/29828#discussion_r493134506 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeJsonExprs.scala ## @@ -0,0 +1,35 @@ +/* + * Licensed to the

[GitHub] [spark] maropu commented on a change in pull request #29828: [SPARK-32948][SQL] Optimize to_json and from_json expression chain

2020-09-22 Thread GitBox
maropu commented on a change in pull request #29828: URL: https://github.com/apache/spark/pull/29828#discussion_r493146562 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeJsonExprs.scala ## @@ -0,0 +1,35 @@ +/* + * Licensed to the

[GitHub] [spark] maropu commented on a change in pull request #29828: [SPARK-32948][SQL] Optimize to_json and from_json expression chain

2020-09-22 Thread GitBox
maropu commented on a change in pull request #29828: URL: https://github.com/apache/spark/pull/29828#discussion_r493141539 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeJsonExprs.scala ## @@ -0,0 +1,35 @@ +/* + * Licensed to the

[GitHub] [spark] maropu commented on a change in pull request #29828: [SPARK-32948][SQL] Optimize to_json and from_json expression chain

2020-09-22 Thread GitBox
maropu commented on a change in pull request #29828: URL: https://github.com/apache/spark/pull/29828#discussion_r493134506 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeJsonExprs.scala ## @@ -0,0 +1,35 @@ +/* + * Licensed to the