maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-547674634
FYI: I added @ulysses-you in the Spark contributor list.
This
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-547673443
Thanks for the contribution, @ulysses-you ! Merged to master.
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-546767730
retest this please
This is an automated message from the
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-546193461
retest this please
This is an automated message from the
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-545758661
Looks ok to me except for the one left point:
https://github.com/apache/spark/pull/25464/files#r322571702
I leave it to the
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-536792531
retest this please
This is an automated message from the
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-532553814
retest this please
This is an automated message from the
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-529742771
Can you check https://github.com/ulysses-you/spark/pull/5?
I roughly brushed up the code based on your pr. Since I didn't
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-527742988
```
- df.hint("REPARTITION", 1, $"c".expr)
```
We need `.expr`? I think this is not intuitive for users... Can you
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-526825762
One more, please list up all the quries that this pr supports, e.g.,
```
Does this PR introduce any user-facing change?
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-526824571
And, I personally think the error message is ambiguous to users, so can you
rethink it again?
```
expects
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-526824476
Have you checked the two cases below?
```
scala> df
res8: org.apache.spark.sql.DataFrame = [a: bigint, b: bigint]
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-525273146
@ulysses-you yea, right.
This is an automated message from the
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-525273082
retest this please
This is an automated message from the
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-525138923
retest this please
This is an automated message from the
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-525113232
oh.. typo..
This is an automated message from the Apache Git
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-524743615
ok to test
This is an automated message from the Apache Git
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-524737227
retest this please
This is an automated message from the
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-524128022
ok to test
This is an automated message from the Apache Git
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-523684735
Yea, that approach looks more reasonable to me. Could you brush up the code
based on the suggestion? @ulysses-you
maropu commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for
sql queries
URL: https://github.com/apache/spark/pull/25464#issuecomment-521852813
@gatorsmile @maryannxue We need this?
This is an automated
21 matches
Mail list logo
