[GitHub] [spark] maropu commented on issue #26961: [SPARK-29708][SQL] Correct aggregated values when grouping sets are duplicated

2020-01-15 Thread GitBox
maropu commented on issue #26961: [SPARK-29708][SQL] Correct aggregated values when grouping sets are duplicated URL: https://github.com/apache/spark/pull/26961#issuecomment-574977574 Yea, I saw the thread in the mail and sure! --

[GitHub] [spark] maropu commented on issue #26961: [SPARK-29708][SQL] Correct aggregated values when grouping sets are duplicated

2020-01-15 Thread GitBox
maropu commented on issue #26961: [SPARK-29708][SQL] Correct aggregated values when grouping sets are duplicated URL: https://github.com/apache/spark/pull/26961#issuecomment-574652108 yea, thanks for the check. I think so, too. --

[GitHub] [spark] maropu commented on issue #26961: [SPARK-29708][SQL] Correct aggregated values when grouping sets are duplicated

2020-01-15 Thread GitBox
maropu commented on issue #26961: [SPARK-29708][SQL] Correct aggregated values when grouping sets are duplicated URL: https://github.com/apache/spark/pull/26961#issuecomment-574651141 @dongjoon-hyun Just a check; we don't need to backport this bugfix to branch-2.4? ---

[GitHub] [spark] maropu commented on issue #26961: [SPARK-29708][SQL] Correct aggregated values when grouping sets are duplicated

2020-01-15 Thread GitBox
maropu commented on issue #26961: [SPARK-29708][SQL] Correct aggregated values when grouping sets are duplicated URL: https://github.com/apache/spark/pull/26961#issuecomment-574650513 Merged to master. This is an automated me

[GitHub] [spark] maropu commented on issue #26961: [SPARK-29708][SQL] Correct aggregated values when grouping sets are duplicated

2020-01-14 Thread GitBox
maropu commented on issue #26961: [SPARK-29708][SQL] Correct aggregated values when grouping sets are duplicated URL: https://github.com/apache/spark/pull/26961#issuecomment-574509802 retest this please This is an automated m

[GitHub] [spark] maropu commented on issue #26961: [SPARK-29708][SQL] Correct aggregated values when grouping sets are duplicated

2020-01-14 Thread GitBox
maropu commented on issue #26961: [SPARK-29708][SQL] Correct aggregated values when grouping sets are duplicated URL: https://github.com/apache/spark/pull/26961#issuecomment-574057425 retest this please This is an automated m

[GitHub] [spark] maropu commented on issue #26961: [SPARK-29708][SQL] Correct aggregated values when grouping sets are duplicated

2020-01-13 Thread GitBox
maropu commented on issue #26961: [SPARK-29708][SQL] Correct aggregated values when grouping sets are duplicated URL: https://github.com/apache/spark/pull/26961#issuecomment-573955810 ok, I'll follow the pgSQL behaviour. This