[GitHub] [spark] maropu commented on issue #26997: [SPARK-30343][SQL] Skip unnecessary checks in RewriteDistinctAggregates

2020-01-10 Thread GitBox
maropu commented on issue #26997: [SPARK-30343][SQL] Skip unnecessary checks in RewriteDistinctAggregates URL: https://github.com/apache/spark/pull/26997#issuecomment-573058738 Thanks, @hvanhovell, @cloud-fan and @viirya ! Merged to master. -

[GitHub] [spark] maropu commented on issue #26997: [SPARK-30343][SQL] Skip unnecessary checks in RewriteDistinctAggregates

2020-01-10 Thread GitBox
maropu commented on issue #26997: [SPARK-30343][SQL] Skip unnecessary checks in RewriteDistinctAggregates URL: https://github.com/apache/spark/pull/26997#issuecomment-572954770 Pending, Jenkins. This is an automated message f

[GitHub] [spark] maropu commented on issue #26997: [SPARK-30343][SQL] Skip unnecessary checks in RewriteDistinctAggregates

2020-01-10 Thread GitBox
maropu commented on issue #26997: [SPARK-30343][SQL] Skip unnecessary checks in RewriteDistinctAggregates URL: https://github.com/apache/spark/pull/26997#issuecomment-572954684 retest this please This is an automated message

[GitHub] [spark] maropu commented on issue #26997: [SPARK-30343][SQL] Skip unnecessary checks in RewriteDistinctAggregates

2020-01-09 Thread GitBox
maropu commented on issue #26997: [SPARK-30343][SQL] Skip unnecessary checks in RewriteDistinctAggregates URL: https://github.com/apache/spark/pull/26997#issuecomment-572907233 cc: @dongjoon-hyun This is an automated message

[GitHub] [spark] maropu commented on issue #26997: [SPARK-30343][SQL] Skip unnecessary checks in RewriteDistinctAggregates

2020-01-09 Thread GitBox
maropu commented on issue #26997: [SPARK-30343][SQL] Skip unnecessary checks in RewriteDistinctAggregates URL: https://github.com/apache/spark/pull/26997#issuecomment-572907195 retest this please This is an automated message

[GitHub] [spark] maropu commented on issue #26997: [SPARK-30343][SQL] Skip unnecessary checks in RewriteDistinctAggregates

2020-01-02 Thread GitBox
maropu commented on issue #26997: [SPARK-30343][SQL] Skip unnecessary checks in RewriteDistinctAggregates URL: https://github.com/apache/spark/pull/26997#issuecomment-570178689 Yea, actually, this is minor optimization and this change has less impact on performance improvements. But, since

[GitHub] [spark] maropu commented on issue #26997: [SPARK-30343][SQL] Skip unnecessary checks in RewriteDistinctAggregates

2019-12-24 Thread GitBox
maropu commented on issue #26997: [SPARK-30343][SQL] Skip unnecessary checks in RewriteDistinctAggregates URL: https://github.com/apache/spark/pull/26997#issuecomment-568815678 cc: @viirya @cloud-fan This is an automated mes