mgaido91 commented on a change in pull request #25011: [SPARK-28170][ML][PYTHON] Uniform Vectors and Matrix documentation URL: https://github.com/apache/spark/pull/25011#discussion_r298818695
########## File path: python/pyspark/ml/linalg/__init__.py ########## @@ -386,14 +386,14 @@ def squared_distance(self, other): def toArray(self): """ - Returns an numpy.ndarray + Returns the underlying numpy.ndarray Review comment: In case of `DenseVector` it means that there is a vector containing the values...and it think makes sense to report it to the users, in order that they know what happens if they modify it... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org