[GitHub] [spark] mgaido91 commented on issue #20350: [SPARK-23179][SQL] Support option to throw exception if overflow occurs during Decimal arithmetic

2019-06-28 Thread GitBox
mgaido91 commented on issue #20350: [SPARK-23179][SQL] Support option to throw exception if overflow occurs during Decimal arithmetic URL: https://github.com/apache/spark/pull/20350#issuecomment-506646538 I see now, sorry for misunderstanding @mickjermsurawong-stripe. I think it is fine

[GitHub] [spark] mgaido91 commented on issue #20350: [SPARK-23179][SQL] Support option to throw exception if overflow occurs during Decimal arithmetic

2019-06-27 Thread GitBox
mgaido91 commented on issue #20350: [SPARK-23179][SQL] Support option to throw exception if overflow occurs during Decimal arithmetic URL: https://github.com/apache/spark/pull/20350#issuecomment-506306487 thanks @cloud-fan and thank you all for the reviews!

[GitHub] [spark] mgaido91 commented on issue #20350: [SPARK-23179][SQL] Support option to throw exception if overflow occurs during Decimal arithmetic

2019-06-27 Thread GitBox
mgaido91 commented on issue #20350: [SPARK-23179][SQL] Support option to throw exception if overflow occurs during Decimal arithmetic URL: https://github.com/apache/spark/pull/20350#issuecomment-506230897 @mickjermsurawong-stripe let me answer to your two comments separately: > At

[GitHub] [spark] mgaido91 commented on issue #20350: [SPARK-23179][SQL] Support option to throw exception if overflow occurs

2019-06-21 Thread GitBox
mgaido91 commented on issue #20350: [SPARK-23179][SQL] Support option to throw exception if overflow occurs URL: https://github.com/apache/spark/pull/20350#issuecomment-504573616 @mickjermsurawong-stripe thanks for your comment. I am updating this PR resolving the conflicts and I hope