[GitHub] [spark] mridulm commented on pull request #37922: [SPARK-40480][SHUFFLE] Remove push-based shuffle data after query finished

mridulm commented on PR #37922: URL: https://github.com/apache/spark/pull/37922#issuecomment-1382708960 Merged to master. Thanks for fixing this @wankunde ! Thanks for the reviews @otterc, @akpatnam25, @yabola :-) -- This is an automated message from the Apache Git Service. To

[GitHub] [spark] mridulm commented on pull request #37922: [SPARK-40480][SHUFFLE] Remove push-based shuffle data after query finished

mridulm commented on PR #37922: URL: https://github.com/apache/spark/pull/37922#issuecomment-1382653651 The tests are failing @wankunde, though I dont think it is due to your PR. Can you please take a look ? And retrigger it if it is unrelated ? Thanks ! -- This is an automated message

[GitHub] [spark] mridulm commented on pull request #37922: [SPARK-40480][SHUFFLE] Remove push-based shuffle data after query finished

mridulm commented on PR #37922: URL: https://github.com/apache/spark/pull/37922#issuecomment-1368518322 I just merged #39316 to unblock this PR, can you update to latest please ? Thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] mridulm commented on pull request #37922: [SPARK-40480][SHUFFLE] Remove push-based shuffle data after query finished

mridulm commented on PR #37922: URL: https://github.com/apache/spark/pull/37922#issuecomment-1368099277 @wankunde, please ping me when you are done with the updates to the PR. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] mridulm commented on pull request #37922: [SPARK-40480][SHUFFLE] Remove push-based shuffle data after query finished

mridulm commented on PR #37922: URL: https://github.com/apache/spark/pull/37922#issuecomment-1366191335 +CC @otterc, can you take a look at this PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] mridulm commented on pull request #37922: [SPARK-40480][SHUFFLE] Remove push-based shuffle data after query finished

mridulm commented on PR #37922: URL: https://github.com/apache/spark/pull/37922#issuecomment-1318239964 I will try to get to this later this week, do let me know if you are still working on it/have pending comments to address. Thanks -- This is an automated message from the Apache Git

[GitHub] [spark] mridulm commented on pull request #37922: [SPARK-40480][SHUFFLE] Remove push-based shuffle data after query finished

mridulm commented on PR #37922: URL: https://github.com/apache/spark/pull/37922#issuecomment-1250590696 We should decouple current implementation details when making protocol changes, and make it extensible for future evolution. In this case though, it is much more straightforward -

[GitHub] [spark] mridulm commented on pull request #37922: [SPARK-40480][SHUFFLE]Remove push-based shuffle data after query finished

mridulm commented on PR #37922: URL: https://github.com/apache/spark/pull/37922#issuecomment-1250359399 +CC @akpatnam25, @otterc - since you were planning to work on this already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to