[GitHub] [spark] panbingkun commented on a diff in pull request #40394: [SPARK-42771][SQL] Refactor HiveGenericUDF

2023-03-14 Thread via GitHub
panbingkun commented on code in PR #40394: URL: https://github.com/apache/spark/pull/40394#discussion_r1136429094 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -235,6 +210,39 @@ private[hive] case class HiveGenericUDF( } } +class

[GitHub] [spark] panbingkun commented on a diff in pull request #40394: [SPARK-42771][SQL] Refactor HiveGenericUDF

2023-03-14 Thread via GitHub
panbingkun commented on code in PR #40394: URL: https://github.com/apache/spark/pull/40394#discussion_r1135621402 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -235,6 +200,56 @@ private[hive] case class HiveGenericUDF( } } +class

[GitHub] [spark] panbingkun commented on a diff in pull request #40394: [SPARK-42771][SQL] Refactor HiveGenericUDF

2023-03-14 Thread via GitHub
panbingkun commented on code in PR #40394: URL: https://github.com/apache/spark/pull/40394#discussion_r1135091254 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -235,6 +200,56 @@ private[hive] case class HiveGenericUDF( } } +class

[GitHub] [spark] panbingkun commented on a diff in pull request #40394: [SPARK-42771][SQL] Refactor HiveGenericUDF

2023-03-14 Thread via GitHub
panbingkun commented on code in PR #40394: URL: https://github.com/apache/spark/pull/40394#discussion_r1135088254 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -235,6 +200,56 @@ private[hive] case class HiveGenericUDF( } } +class

[GitHub] [spark] panbingkun commented on a diff in pull request #40394: [SPARK-42771][SQL] Refactor HiveGenericUDF

2023-03-14 Thread via GitHub
panbingkun commented on code in PR #40394: URL: https://github.com/apache/spark/pull/40394#discussion_r1135085953 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -129,58 +129,25 @@ private[hive] class DeferredObjectAdapter(oi: ObjectInspector,

[GitHub] [spark] panbingkun commented on a diff in pull request #40394: [SPARK-42771][SQL] Refactor HiveGenericUDF

2023-03-14 Thread via GitHub
panbingkun commented on code in PR #40394: URL: https://github.com/apache/spark/pull/40394#discussion_r1135084756 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -191,18 +157,18 @@ private[hive] case class HiveGenericUDF( override protected def

[GitHub] [spark] panbingkun commented on a diff in pull request #40394: [SPARK-42771][SQL] Refactor HiveGenericUDF

2023-03-14 Thread via GitHub
panbingkun commented on code in PR #40394: URL: https://github.com/apache/spark/pull/40394#discussion_r1135066392 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -129,58 +129,25 @@ private[hive] class DeferredObjectAdapter(oi: ObjectInspector,

[GitHub] [spark] panbingkun commented on a diff in pull request #40394: [SPARK-42771][SQL] Refactor HiveGenericUDF

2023-03-13 Thread via GitHub
panbingkun commented on code in PR #40394: URL: https://github.com/apache/spark/pull/40394#discussion_r1134810496 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -235,6 +200,56 @@ private[hive] case class HiveGenericUDF( } } +class

[GitHub] [spark] panbingkun commented on a diff in pull request #40394: [SPARK-42771][SQL] Refactor HiveGenericUDF

2023-03-13 Thread via GitHub
panbingkun commented on code in PR #40394: URL: https://github.com/apache/spark/pull/40394#discussion_r1134807339 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -235,6 +200,56 @@ private[hive] case class HiveGenericUDF( } } +class

[GitHub] [spark] panbingkun commented on a diff in pull request #40394: [SPARK-42771][SQL] Refactor HiveGenericUDF

2023-03-13 Thread via GitHub
panbingkun commented on code in PR #40394: URL: https://github.com/apache/spark/pull/40394#discussion_r1134790402 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -235,6 +200,56 @@ private[hive] case class HiveGenericUDF( } } +class